fix: implement missing utilities and fix edge-case bugs - #266
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero - date-utils: round hours-to-days in formatRelative to fix off-by-one - validator: allow long TLDs in isEmail and ports in isUrl - string-utils: implement truncate and wordCount - task-manager: implement remove, update, and sortBy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests and implements missing functionality across the utility library. All 60 tests now pass with no regressions.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0(previously returnedInfinity).src/date-utils.ts—formatRelativeusesMath.roundfor the hours→days conversion, fixing an off-by-one that reported "1 day ago" for ~36h diffs.src/validator.ts—isEmailregex widened to accept long TLDs (e.g..museum);isUrlno longer rejects URLs with ports (e.g.http://localhost:3000).src/string-utils.ts— implementedtruncate(word-boundary truncation with"..."counting towardmaxLength) andwordCount.src/task-manager.ts— implementedremove,update, andsortBy.Testing
bun test→ 60 pass, 0 fail.Notes / assumptions
🤖 Generated autonomously.